Adding async await to DataLoader #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, swift-actions/setup-swift does not work with async await. |
NeedleInAJayStack
requested changes
Jul 25, 2022
There was a problem hiding this comment.
Oh you beat me to this!
Awesome changes, they look excellent. Just a small change request on the test Action yaml.
Thanks for your hard work @d-exclaimation!
NeedleInAJayStack
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simply adds extensions to use DataLoader with async await.
This also includes test cases using these async await extensions derived from
DataLoaderTests, but without some test cases as it seemed redundant.Another thing to note is that the
ConcurrentBatchLoadFunctionis set to beSendable, which makes sure it is concurrent safe. I think it makes a lot of sense in this case.