Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

there is a trouble in windows system when user pass the path of json file #253

Closed
yangislet opened this issue Jan 22, 2021 · 2 comments
Closed

there is a trouble in windows system when user pass the path of json file #253

yangislet opened this issue Jan 22, 2021 · 2 comments

Comments

@yangislet
Copy link

The "configureContext" function in the path of graphwalker-java\4.3.0\graphwalker-java-4.3.0.jar!\org\graphwalker\java\test\TestExecutor.class is not ok.This function replace the path of file,however it only support Mas OS with "/". I suggest that you should auto identify os system. Thanks!

Class.forName(path.getParent().toString().replace('/', '.') + "." + examineContext.getModel().getName()).isAssignableFrom(context.getClass())
KristianKarl added a commit to KristianKarl/graphwalker-project that referenced this issue Feb 24, 2021
@KristianKarl
Issue GraphWalker#253 Fix for hard coded file separator
ff1ea38
@KristianKarl
Copy link
Contributor

Fixed by PR #257

@KristianKarl
Copy link
Contributor

Good catch!
Thanks for you report.

KristianKarl added a commit that referenced this issue Feb 24, 2021
@KristianKarl
Merge pull request #257 from KristianKarl/master
82fdaee 
Fix issue #253  - hard coded file separator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yangislet @KristianKarl