-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Singleton generator #218
Merged
KristianKarl
merged 11 commits into
GraphWalker:master
from
KristianKarl:singletonGenerator
Nov 26, 2019
Merged
Singleton generator #218
KristianKarl
merged 11 commits into
GraphWalker:master
from
KristianKarl:singletonGenerator
Nov 26, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore/condition/ComplexConditionsTest.java
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
============================================
- Coverage 76.17% 76.07% -0.11%
- Complexity 1176 1187 +11
============================================
Files 126 127 +1
Lines 4332 4368 +36
Branches 655 656 +1
============================================
+ Hits 3300 3323 +23
- Misses 802 814 +12
- Partials 230 231 +1 |
One problem with this PR is the introduction of a singleton, which complicates things when running unit tests. See https://dzone.com/articles/singleton-anti-pattern |
@nilols a review pretty plz? |
nilols
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets a user to reproduce the same path over and over again.
When graphwalker uses the random generator, the seed is logged (on INFO level). For example:
That seed can be reused when put in the json file, add for instance
"seed": 67300799054828,
to the file.See petClinicWithSeed.json for an example.