Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear GraphWalker developers,
I recently made a fork of the project, where I implemented an additional generator and stop condition. These enable the user to define a custom edge sequence along which the software will execute the walk on the supplied graph.
My motivation for these developments was to make it possible for the user to define any edge sequence, either customized by themselves, or generated by external tools. In my opinion, this feature might help diversify the use cases of the GraphWalker project.
I implemented the feature of predefined paths by extending the JSON input model in the io module with a
predefinedPathEdgeIds
member. The user has to define the sequence of edge IDs in this array (of strings). This array exists similarly as a member in the graph model classes in the core module. I made a few additions in the context class by keeping a record of the current edge index during the execution process. The generator calculates the next element in the walk using the array of edges stored in the graph model and the current edge index kept by the context. The stop condition keeps track of when the walk has stepped on the target vertex of the last edge defined in the predefined path.For these features, I wrote multiple unit tests to make sure my implementation is correct. I tested all features separately, and I tried to think of all possible situations that might occur during execution.
There are a few possible future developments for this new feature that I can suggest. One of them could be the extension of the GraphWalker Studio GUI with an input box where the user defines the predefined path. Currently it can only be defined in the JSON input model.
I hope I raised your interest with this development and that my contribution can be a part of the GraphWalker project.
Sincerely, Zsolt Csáky