add network location setting and add network location provider to config_locationProviderPackageNames #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soupslurpr
changed the title
This reverts commit 5a8d91b5fac0a1ae597de359128e0706776ce3a7.
When an unhandled exception occured, binder connections were closed with IPCThreadState::stopProcess() before the invocation of java.lang.Thread#dispatchUncaughtException(). By default, that method tries to report the crash via ActivityManager#handleApplicationCrash(), which always failed due to the closed binder connection. This meant that the crash dialog was never shown and additional crash handling was skipped. Zygote-based spawning never calls IPCThreadState::stopProcess().
Needed for exec spawning, to pass custom flags to the kernel.
Chromium browser and its derivatives setup a seccomp syscall filter in their isolated processes, which blocks creation of new userfaultfds. Since 14 QPR2, ART uses a new userfaultfd-based GC. When zygote-based process spawning is used, userfaultfd GC is initialized before any of app's code is executed, i.e. before Chromium's seccomp syscall filter is installed. When exec spawning is used, userfaultfd GC initialization is delayed until first garbage collection. Chromium's seccomp syscall filter is already installed at that point. This leads to crashes of isolated Chromium processes (both browser and WebView), with the following log messages: E cr_seccomp: ../../sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc:**CRASHING**:seccomp-bpf failure in syscall E cr_seccomp: nr=0x11a arg1=0x80001 arg2=0xc arg3=0xffffffffffffffff arg4=0xc As a workaround, perform early initialization of ART userfaultfd GC in isolated processes by calling System.gc() before executing app's code. On Pixel 8, this increases startup latency by around 4 to 10 milliseconds.
Original commit: c1d9385
Some upstream methods are used to check if unlocking is possible when it is known that a biometric auth has succeeded, but they don't and can't take into account biometric second factor. Renaming these methods gives us build errors for future callers, so we can make sure they are safe.
Extracted from: commit dc6270f Author: Fred Underwood <underwoodfred@proton.me> Date: Sat Dec 21 16:25:15 2024 +1000 add second factor to DevicePolicyManagerService
Extracted from: commit 3caf1f2 Author: Fred Underwood <underwoodfred@proton.me> Date: Sat Dec 21 16:40:05 2024 +1000 add second factor to LockSettingsService
Extracted from: commit caa335d Author: Fred Underwood <underwoodfred@proton.me> Date: Sun Dec 22 06:53:47 2024 +1000 add second factor UI
hamzabhatti5253
approved these changes
Jan 2, 2025
hamzabhatti5253
approved these changes
Jan 2, 2025
|
@hamzabhatti5253 Why are you repeatedly marking this approved? |
soupslurpr
force-pushed
the
network-location
branch
from
69c5b5e to
8d505d2
Compare
soupslurpr
force-pushed
the
network-location
branch
from
8d505d2 to
146ea80
Compare
soupslurpr
changed the title
thestinger
force-pushed
the
15
branch
9 times, most recently
from
3d97c25 to
f3469eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network location changeset:
https://github.com/soupslurpr/platform_packages_apps_NetworkLocation
#61 (you are here)
GrapheneOS/platform_packages_modules_Wifi#37
GrapheneOS/platform_packages_modules_Wifi#38
GrapheneOS/platform_build#65
GrapheneOS/platform_packages_apps_Settings#296