Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): consolidate all "config"-related funcs in "ContextInfo" #1003

Merged
merged 1 commit into from
Sep 24, 2021
Merged

refactor(cli): consolidate all "config"-related funcs in "ContextInfo" #1003

merged 1 commit into from
Sep 24, 2021

Conversation

marshallmallows
Copy link
Collaborator

@marshallmallows marshallmallows commented Sep 10, 2021 •
edited
Loading

No description provided.

@coveralls
Copy link

coveralls commented Sep 10, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1268467797

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.059%
Totals Coverage Status
Change from base Build 1265701070: 0.0%
Covered Lines: 6136
Relevant Lines: 7130
💛 - Coveralls

Lee-000
Lee-000 reviewed Sep 10, 2021
View reviewed changes
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T17139_fix_reading_profiles_repeatedly branch from 51bc913 to 9a61501 Compare September 10, 2021 08:23
@marshallmallows marshallmallows force-pushed the T17139_fix_reading_profiles_repeatedly branch 2 times, most recently from 88de4ed to a40daf5 Compare September 14, 2021 04:04
Lee-000
Lee-000 requested changes Sep 15, 2021
View reviewed changes
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
tensorbay/cli/utility.py Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T17139_fix_reading_profiles_repeatedly branch from a40daf5 to 34defee Compare September 16, 2021 08:28
Lee-000
Lee-000 reviewed Sep 16, 2021
View reviewed changes
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T17139_fix_reading_profiles_repeatedly branch from 34defee to 4769a51 Compare September 16, 2021 09:40
linjiX
linjiX requested changes Sep 18, 2021
View reviewed changes
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
linjiX
linjiX requested changes Sep 18, 2021
View reviewed changes
tensorbay/cli/auth.py Show resolved Hide resolved
linjiX
linjiX requested changes Sep 18, 2021
View reviewed changes
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
linjiX
linjiX requested changes Sep 18, 2021
View reviewed changes
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
linjiX
linjiX requested changes Sep 18, 2021
View reviewed changes
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T17139_fix_reading_profiles_repeatedly branch from 4769a51 to c2c444f Compare September 18, 2021 08:12
@marshallmallows marshallmallows changed the title feat(cli): fix reading 'config_parser["profiles"]' repeatedly in auth refactor(cli): consolidate all "config"-related funcs in "ContextInfo" Sep 18, 2021
linjiX
linjiX requested changes Sep 18, 2021
View reviewed changes
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T17139_fix_reading_profiles_repeatedly branch from c2c444f to fceff54 Compare September 18, 2021 08:30
@marshallmallows marshallmallows force-pushed the T17139_fix_reading_profiles_repeatedly branch 2 times, most recently from 301db73 to 2b66fb6 Compare September 22, 2021 05:39
Lee-000
Lee-000 requested changes Sep 23, 2021
View reviewed changes
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T17139_fix_reading_profiles_repeatedly branch from 2b66fb6 to da71b66 Compare September 23, 2021 09:09
@marshallmallows marshallmallows force-pushed the T17139_fix_reading_profiles_repeatedly branch from da71b66 to 439d5c0 Compare September 24, 2021 04:07
@marshallmallows marshallmallows force-pushed the T17139_fix_reading_profiles_repeatedly branch from 439d5c0 to a099410 Compare September 24, 2021 04:13
@marshallmallows marshallmallows merged commit 18a393a into Graviti-AI:main Sep 24, 2021
@marshallmallows marshallmallows deleted the T17139_fix_reading_profiles_repeatedly branch September 24, 2021 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-000 Lee-000 Lee-000 approved these changes

@linjiX linjiX linjiX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marshallmallows @coveralls @Lee-000 @linjiX