Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(utility): add "URL" class for get and update url #1088

Merged
merged 1 commit into from
Nov 5, 2021
Merged

feat(utility): add "URL" class for get and update url #1088

merged 1 commit into from
Nov 5, 2021

Conversation

AChenQ
Copy link
Collaborator

@AChenQ AChenQ commented Nov 4, 2021 •
edited
Loading

No description provided.

@AChenQ AChenQ requested review from Lee-000 and linjiX as code owners November 4, 2021 08:42
@coveralls
Copy link

coveralls commented Nov 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1424241359

  • 40 of 46 (86.96%) changed or added relevant lines in 9 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 87.133%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tensorbay/client/segment.py 4 5 80.0%
tensorbay/utility/file.py 16 21 76.19%
Files with Coverage Reduction New Missed Lines %
tensorbay/utility/file.py 1 85.19%
Totals Coverage Status
Change from base Build 1424185055: 0.04%
Covered Lines: 7530
Relevant Lines: 8642
💛 - Coveralls

@AChenQ AChenQ force-pushed the T19468_add_url_getter branch 4 times, most recently from 0139803 to 4632c0a Compare November 4, 2021 09:02
linjiX
linjiX requested changes Nov 4, 2021
View reviewed changes
tensorbay/utility/file.py Outdated Show resolved Hide resolved
tensorbay/utility/file.py Show resolved Hide resolved
tensorbay/utility/file.py Outdated Show resolved Hide resolved
tensorbay/client/segment.py Outdated Show resolved Hide resolved
linjiX
linjiX requested changes Nov 4, 2021
View reviewed changes
tensorbay/utility/file.py Outdated Show resolved Hide resolved
@AChenQ AChenQ force-pushed the T19468_add_url_getter branch from 4632c0a to ef1e6dd Compare November 4, 2021 09:20
linjiX
linjiX requested changes Nov 4, 2021
View reviewed changes
tensorbay/utility/file.py Outdated Show resolved Hide resolved
linjiX
linjiX reviewed Nov 4, 2021
View reviewed changes
tensorbay/utility/file.py Outdated Show resolved Hide resolved
@AChenQ AChenQ force-pushed the T19468_add_url_getter branch from ef1e6dd to a929f9a Compare November 4, 2021 11:24
@AChenQ AChenQ changed the title feat(utility): add "Url" class for get and update url feat(utility): add "URL" class for get and update url Nov 4, 2021
@AChenQ AChenQ force-pushed the T19468_add_url_getter branch from a929f9a to 70a1943 Compare November 4, 2021 11:31
linjiX
linjiX requested changes Nov 4, 2021
View reviewed changes
tensorbay/utility/file.py Outdated Show resolved Hide resolved
@AChenQ AChenQ force-pushed the T19468_add_url_getter branch 2 times, most recently from 1c99b90 to d4c2388 Compare November 5, 2021 02:23
@AChenQ AChenQ force-pushed the T19468_add_url_getter branch from d4c2388 to 0aedec0 Compare November 5, 2021 03:20
@AChenQ AChenQ force-pushed the T19468_add_url_getter branch from 0aedec0 to 583c3e0 Compare November 5, 2021 03:26
@AChenQ AChenQ merged commit 7d1fa11 into Graviti-AI:main Nov 5, 2021
@AChenQ AChenQ deleted the T19468_add_url_getter branch November 5, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linjiX linjiX linjiX approved these changes

@Lee-000 Lee-000 Lee-000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AChenQ @coveralls @Lee-000 @linjiX