docs: support deleting automatically generated files via make clean #1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1498692749
💛 - Coveralls |
linjiX
requested changes
Nov 24, 2021
docs/Makefile
Outdated
|
|
||
| clean: | ||
| -rm -rf $(BUILDDIR)/* | ||
| -rm -rf source/reference/api/api_rst/ |
There was a problem hiding this comment.
use SOURCEDIR rather than source?
There was a problem hiding this comment.
Also shall we put the generated files to an obvious position?
we cannot know that this folder contains generated files from its name source/reference/api/api_rst/.
There was a problem hiding this comment.
So we could use file name "generated" uniformly to refer to automatically generated files？just as "index" stands for directories.
There was a problem hiding this comment.
I think it is OK to use "generated"
graczhual
force-pushed
the
T19880_make_clean
branch
from
f840886 to
13b470e
Compare
graczhual
force-pushed
the
T19880_make_clean
branch
from
13b470e to
8c2c3c6
Compare
linjiX
approved these changes
Nov 25, 2021
graczhual
force-pushed
the
T19880_make_clean
branch
from
8c2c3c6 to
f044c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.