-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apps): adapt OpenAPI listEvaluations #1136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1514774746
💛 - Coveralls |
linjiX
requested changes
Nov 26, 2021
tensorbay/apps/sextant.py
Outdated
self.status = status | ||
|
||
def __repr__(self) -> str: | ||
read_time = time.strftime("%Y-%m-%d %H:%M:%S", time.localtime(self.create_at)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why display time in repr
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add time information to help users distinguish evaluations.
I want to add a title
field to do this later.
linjiX
requested changes
Nov 26, 2021
AChenQ
force-pushed
the
T20149_list_eva
branch
from
November 26, 2021 10:40
c050d63
to
f312201
Compare
linjiX
requested changes
Nov 26, 2021
AChenQ
force-pushed
the
T20149_list_eva
branch
from
November 29, 2021 02:23
f312201
to
043f08a
Compare
linjiX
reviewed
Nov 29, 2021
AChenQ
force-pushed
the
T20149_list_eva
branch
from
November 29, 2021 04:06
043f08a
to
6b88943
Compare
linjiX
approved these changes
Nov 29, 2021
AChenQ
changed the title
feat(apps): adapt OpenAPI listEvaluation
feat(apps): adapt OpenAPI listEvaluations
Nov 29, 2021
AChenQ
force-pushed
the
T20149_list_eva
branch
from
November 29, 2021 06:49
6b88943
to
e919e37
Compare
AChenQ
force-pushed
the
T20149_list_eva
branch
from
November 29, 2021 06:52
e919e37
to
e54d87c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.