Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps): adapt OpenAPI listEvaluations #1136

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

AChenQ
Copy link
Collaborator

@AChenQ AChenQ commented Nov 26, 2021

No description provided.

@AChenQ AChenQ requested a review from linjiX as a code owner November 26, 2021 08:55
@coveralls
Copy link

coveralls commented Nov 26, 2021

Pull Request Test Coverage Report for Build 1514774746

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.593%

Totals Coverage Status
Change from base Build 1514432110: 0.0%
Covered Lines: 7615
Relevant Lines: 8794

💛 - Coveralls

self.status = status

def __repr__(self) -> str:
read_time = time.strftime("%Y-%m-%d %H:%M:%S", time.localtime(self.create_at))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why display time in repr?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add time information to help users distinguish evaluations.
I want to add a title field to do this later.

tensorbay/apps/sextant.py Outdated Show resolved Hide resolved
tensorbay/apps/sextant.py Outdated Show resolved Hide resolved
tensorbay/apps/sextant.py Outdated Show resolved Hide resolved
tensorbay/apps/sextant.py Outdated Show resolved Hide resolved
@linjiX linjiX requested a review from Lee-000 November 29, 2021 03:58
@AChenQ AChenQ changed the title feat(apps): adapt OpenAPI listEvaluation feat(apps): adapt OpenAPI listEvaluations Nov 29, 2021
@AChenQ AChenQ merged commit a9de1c2 into Graviti-AI:main Nov 29, 2021
@AChenQ AChenQ deleted the T20149_list_eva branch November 29, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants