Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add update to Job #1174

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

graczhual
Copy link
Contributor

@graczhual graczhual commented Dec 21, 2021

No description provided.

@graczhual graczhual requested a review from AChenQ as a code owner December 21, 2021 08:09
@coveralls
Copy link

coveralls commented Dec 21, 2021

Pull Request Test Coverage Report for Build 1606349141

  • 4 of 14 (28.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 86.092%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tensorbay/client/job.py 4 14 28.57%
Totals Coverage Status
Change from base Build 1606342145: -0.09%
Covered Lines: 7682
Relevant Lines: 8923

💛 - Coveralls

@@ -67,6 +73,7 @@ def __init__( # pylint: disable=too-many-arguments
result: Optional[Dict[str, Any]],
description: Optional[str] = "",
) -> None:
self._job_updater = job_updater
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we have client in Job, can we just use client to update the job rather than use a updater?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in that case, we need to write the open_api_do about get_job both at class Job and class JobMixin.

tensorbay/client/job.py Outdated Show resolved Hide resolved
tensorbay/client/job.py Outdated Show resolved Hide resolved
tensorbay/client/job.py Outdated Show resolved Hide resolved
@graczhual graczhual merged commit c74eb30 into Graviti-AI:main Dec 21, 2021
@graczhual graczhual deleted the T20651_update_job branch December 21, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants