-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): add update to Job #1174
Conversation
Pull Request Test Coverage Report for Build 1606349141
💛 - Coveralls |
@@ -67,6 +73,7 @@ def __init__( # pylint: disable=too-many-arguments | |||
result: Optional[Dict[str, Any]], | |||
description: Optional[str] = "", | |||
) -> None: | |||
self._job_updater = job_updater |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have client in Job, can we just use client to update the job rather than use a updater?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in that case, we need to write the open_api_do about get_job both at class Job
and class JobMixin
.
b1afefd
to
a309f32
Compare
a309f32
to
f7fff93
Compare
f7fff93
to
e4a2dc2
Compare
e4a2dc2
to
63b1bc0
Compare
No description provided.