Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(opendataset): add dataloader for HKD #1194

Merged
merged 1 commit into from
Jan 19, 2022
Merged

feat(opendataset): add dataloader for HKD #1194

merged 1 commit into from
Jan 19, 2022
+134 −0

Conversation

Joey9933
Copy link
Collaborator

@Joey9933 Joey9933 commented Jan 10, 2022 •
edited
Loading

No description provided.

@Joey9933 Joey9933 requested a review from linjiX as a code owner January 10, 2022 06:51
@linjiX linjiX requested a review from Lee-000 January 10, 2022 06:53
Lee-000
Lee-000 requested changes Jan 10, 2022
View reviewed changes
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
@Joey9933 Joey9933 changed the title docs: first commit for HDK loader style: split the segments according to different subjects Jan 10, 2022
@Joey9933 Joey9933 changed the title style: split the segments according to different subjects docs: first commit for HDK loader Jan 10, 2022
Lee-000
Lee-000 requested changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@Lee-000 Lee-000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message is incorrect. It should be feat with scope. And the message should be an action.

tensorbay/opendataset/HKD/catalog.json Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1715983811

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.422%
Totals Coverage Status
Change from base Build 1711324666: 0.0%
Covered Lines: 7803
Relevant Lines: 9029
💛 - Coveralls

@Joey9933 Joey9933 changed the title docs: first commit for HDK loader feat(opendataset): add dataloader for HKD Jan 12, 2022
linjiX
linjiX requested changes Jan 12, 2022
View reviewed changes
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
@Joey9933 Joey9933 requested review from Lee-000 and linjiX January 13, 2022 03:13
linjiX
linjiX requested changes Jan 13, 2022
View reviewed changes
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
Lee-000
Lee-000 requested changes Jan 13, 2022
View reviewed changes
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
@Joey9933 Joey9933 requested a review from graczhual as a code owner January 13, 2022 07:51
@Joey9933 Joey9933 force-pushed the T11570_HKD branch 3 times, most recently from 31ce4b0 to 7ac12af Compare January 13, 2022 09:54
@Joey9933 Joey9933 force-pushed the T11570_HKD branch 2 times, most recently from 09486bf to 29561b0 Compare January 13, 2022 11:52
@Joey9933 Joey9933 requested a review from graczhual January 14, 2022 07:00
@Joey9933 Joey9933 requested a review from Lee-000 January 14, 2022 07:00
linjiX
linjiX requested changes Jan 14, 2022
View reviewed changes
tensorbay/opendataset/HKD/loader.py Outdated Show resolved Hide resolved
@Joey9933 Joey9933 force-pushed the T11570_HKD branch 2 times, most recently from f8aa579 to 15a5927 Compare January 17, 2022 03:57
@Joey9933 Joey9933 merged commit 2a2d44a into Graviti-AI:main Jan 19, 2022
@Joey9933 Joey9933 deleted the T11570_HKD branch January 19, 2022 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-000 Lee-000 Lee-000 approved these changes

@linjiX linjiX linjiX approved these changes

@graczhual graczhual graczhual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joey9933 @coveralls @Lee-000 @linjiX @graczhual