feat(client): add implementation about class "BasicSearchJob" #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1949687911
💛 - Coveralls |
willandfree
force-pushed
the
T21745_huhan
branch
2 times, most recently
from
9a58781 to
4e4a518
Compare
graczhual
reviewed
Mar 8, 2022
tensorbay/client/job.py
Outdated
Comment on lines
325
to
333
| @property | ||
| def is_fusion(self) -> bool: | ||
| """Know whether it is from fusion dataset. | ||
|
|
||
| Returns: | ||
| Whether the BasicSearchJob is from fusion dataset. | ||
|
|
||
| """ | ||
| return self._is_fusion |
There was a problem hiding this comment.
do not need this property
AChenQ
requested changes
Mar 8, 2022
tensorbay/client/job.py
Outdated
| } | ||
| client: The :class:`~tensorbay.client.requests.Client`. | ||
| dataset_id: Dataset ID. | ||
| job_updater: The function to update the information of the SquashAndMergeJob instance. |
There was a problem hiding this comment.
Does BasicSerchJob also need a job_updater?
tensorbay/client/job.py
Outdated
| @@ -286,11 +286,107 @@ def from_response_body( # type: ignore[override] # pylint: disable=arguments-d | |||
| class BasicSearchJob(Job): | |||
| """This class defines :class:`BasicSearchJob`.""" | |||
|
|
|||
| _T = TypeVar("_T", bound="BasicSearchJob") | |||
|
|
|||
| def __init__( # pylint: disable=too-many-arguments | |||
There was a problem hiding this comment.
Use keyword arguments to avoid pylint error.
willandfree
force-pushed
the
T21745_huhan
branch
2 times, most recently
from
fef8629 to
f085dc4
Compare
AChenQ
approved these changes
Mar 8, 2022
graczhual
approved these changes
Mar 8, 2022
willandfree
added a commit
to willandfree/tensorbay-python-sdk
that referenced
this pull request
Mar 8, 2022
willandfree
force-pushed
the
T21745_huhan
branch
from
f085dc4 to
f2feb63
Compare
willandfree
force-pushed
the
T21745_huhan
branch
from
f2feb63 to
90ef878
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.