feat(label): add "MultiPolyline2DSubcatalog" & "LabeledMultiPolyline2D" #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1036748837
💛 - Coveralls |
AChenQ
force-pushed
the
T16640_add_multipolyline
branch
from
76df851 to
7970376
Compare
Lee-000
requested changes
Jul 14, 2021
tensorbay/label/label_polyline.py
Outdated
Comment on lines
244
to
247
| >>> categories = NameList() | ||
| >>> categories.append(CategoryInfo("a")) | ||
| >>> attributes = NameList() | ||
| >>> attributes.append(AttributeInfo("gender", enum=["female", "male"])) |
There was a problem hiding this comment.
Use MultiPolyline2DSubcatalog.add_category and MultiPolyline2DSubcatalog.add_attribute instead.
linjiX
requested changes
Jul 14, 2021
tensorbay/label/label_polyline.py
Outdated
| ... "instance": "12345", | ||
| ... } | ||
| >>> LabeledMultiPolyline2D.loads(contents) | ||
| LabeledPolyline2D [ |
tensorbay/utility/attr.py
Outdated
| @@ -111,7 +111,10 @@ def __init_subclass__(cls) -> None: | |||
| type_ = cls.__annotations__.pop(_ATTRS_BASE, None) | |||
| if type_: | |||
| cls._attrs_base.loader = type_._loads # pylint: disable=protected-access | |||
| cls._attrs_base.dumper = type_.dumps | |||
| if hasattr(type_, "_dumps"): | |||
There was a problem hiding this comment.
cls._attrs_base.dumper = type_.dumps if hasattr(type_, "_dumps") else type_.dumps
AChenQ
force-pushed
the
T16640_add_multipolyline
branch
6 times, most recently
from
f4efeab to
f5edcba
Compare
linjiX
requested changes
Jul 15, 2021
tensorbay/utility/attr.py
Outdated
| @@ -111,7 +111,11 @@ def __init_subclass__(cls) -> None: | |||
| type_ = cls.__annotations__.pop(_ATTRS_BASE, None) | |||
| if type_: | |||
| cls._attrs_base.loader = type_._loads # pylint: disable=protected-access | |||
| cls._attrs_base.dumper = type_.dumps | |||
| cls._attrs_base.dumper = ( | |||
There was a problem hiding this comment.
= getattr(type_, "_dumps", type_.dumps)?
AChenQ
force-pushed
the
T16640_add_multipolyline
branch
from
f5edcba to
45043fe
Compare
linjiX
approved these changes
Jul 16, 2021
AChenQ
force-pushed
the
T16640_add_multipolyline
branch
from
45043fe to
e07ef8e
Compare
Lee-000
approved these changes
Jul 16, 2021
AChenQ
force-pushed
the
T16640_add_multipolyline
branch
from
e07ef8e to
f0be84e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.