Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename Polygon2D to Polygon #822

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

edsn60
Copy link
Collaborator

@edsn60 edsn60 commented Jul 13, 2021

No description provided.

@edsn60 edsn60 requested review from AChenQ and Lee-000 as code owners July 13, 2021 10:57
@coveralls
Copy link

coveralls commented Jul 13, 2021

Pull Request Test Coverage Report for Build 1029407308

  • 65 of 65 (100.0%) changed or added relevant lines in 12 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.645%

Totals Coverage Status
Change from base Build 1029015056: 0.0%
Covered Lines: 5105
Relevant Lines: 6177

💛 - Coveralls

@edsn60 edsn60 force-pushed the T16692_refactor branch 2 times, most recently from cca2a93 to de33c18 Compare July 13, 2021 11:08
@@ -19,7 +19,7 @@
:class:`~tensorbay.label.label_classification.Classification` classification type of label
:class:`~tensorbay.label.label_box.LabeledBox2D` 2D bounding box type of label
:class:`~tensorbay.label.label_box.LabeledBox3D` 3D bounding box type of label
:class:`~tensorbay.label.label_polygon.LabeledPolygon2D` 2D polygon type of label
:class:`~tensorbay.label.label_polygon.LabeledPolygon` 2D polygon type of label
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polygon type of label


:class:`Polygon2DSubcatalog` defines the subcatalog for 2D polygon type of labels.
:class:`PolygonSubcatalog` defines the subcatalog for 2D polygon type of labels.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete 2D

@SubcatalogTypeRegister(LabelType.POLYGON2D)
class Polygon2DSubcatalog( # pylint: disable=too-many-ancestors
@SubcatalogTypeRegister(LabelType.POLYGON)
class PolygonSubcatalog( # pylint: disable=too-many-ancestors
SubcatalogBase, IsTrackingMixin, CategoriesMixin, AttributesMixin
):
"""This class defines the subcatalog for 2D polygon type of labels.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete 2D


:class:`LabeledPolygon2D` is the 2D polygon type of label,
:class:`LabeledPolygon` is the 2D polygon type of label,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 2D

_LabelBase.__init__(self, category, attributes, instance)

@classmethod
def loads(cls: Type[_T], contents: Dict[str, Any]) -> _T: # type: ignore[override]
"""Loads a LabeledPolygon2D from a dict containing the information of the label.
"""Loads a LabeledPolygon from a dict containing the information of the label.

Arguments:
contents: A dict containing the information of the 2D polygon label.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 2D

@@ -182,18 +182,18 @@ def dumps(self) -> Dict[str, Any]: # type: ignore[override]
A dict containing all the information of the 2D polygon label.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 2D

@edsn60 edsn60 force-pushed the T16692_refactor branch from de33c18 to b414916 Compare July 14, 2021 04:43
:class:`.Keypoints2DSubcatalog` subcatalog for 2D polygon type of label
:class:`.Polygon2DSubcatalog` subcatalog for 2D polyline type of label
:class:`.Keypoints2DSubcatalog` subcatalog for polygon type of label
:class:`.PolygonSubcatalog` subcatalog for 2D polyline type of label
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong order.

@edsn60 edsn60 force-pushed the T16692_refactor branch from b414916 to a0971b3 Compare July 14, 2021 06:45
PR Closed: Graviti-AI#822
@edsn60 edsn60 force-pushed the T16692_refactor branch from a0971b3 to f71f882 Compare July 14, 2021 07:32
@edsn60 edsn60 merged commit 21a3186 into Graviti-AI:main Jul 14, 2021
@edsn60 edsn60 deleted the T16692_refactor branch July 14, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants