-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename Polygon2D to Polygon #822
Conversation
Pull Request Test Coverage Report for Build 1029407308
💛 - Coveralls |
cca2a93
to
de33c18
Compare
tensorbay/label/label.py
Outdated
@@ -19,7 +19,7 @@ | |||
:class:`~tensorbay.label.label_classification.Classification` classification type of label | |||
:class:`~tensorbay.label.label_box.LabeledBox2D` 2D bounding box type of label | |||
:class:`~tensorbay.label.label_box.LabeledBox3D` 3D bounding box type of label | |||
:class:`~tensorbay.label.label_polygon.LabeledPolygon2D` 2D polygon type of label | |||
:class:`~tensorbay.label.label_polygon.LabeledPolygon` 2D polygon type of label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
polygon type of label
tensorbay/label/label_polygon.py
Outdated
|
||
:class:`Polygon2DSubcatalog` defines the subcatalog for 2D polygon type of labels. | ||
:class:`PolygonSubcatalog` defines the subcatalog for 2D polygon type of labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete 2D
tensorbay/label/label_polygon.py
Outdated
@SubcatalogTypeRegister(LabelType.POLYGON2D) | ||
class Polygon2DSubcatalog( # pylint: disable=too-many-ancestors | ||
@SubcatalogTypeRegister(LabelType.POLYGON) | ||
class PolygonSubcatalog( # pylint: disable=too-many-ancestors | ||
SubcatalogBase, IsTrackingMixin, CategoriesMixin, AttributesMixin | ||
): | ||
"""This class defines the subcatalog for 2D polygon type of labels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete 2D
tensorbay/label/label_polygon.py
Outdated
|
||
:class:`LabeledPolygon2D` is the 2D polygon type of label, | ||
:class:`LabeledPolygon` is the 2D polygon type of label, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove 2D
tensorbay/label/label_polygon.py
Outdated
_LabelBase.__init__(self, category, attributes, instance) | ||
|
||
@classmethod | ||
def loads(cls: Type[_T], contents: Dict[str, Any]) -> _T: # type: ignore[override] | ||
"""Loads a LabeledPolygon2D from a dict containing the information of the label. | ||
"""Loads a LabeledPolygon from a dict containing the information of the label. | ||
|
||
Arguments: | ||
contents: A dict containing the information of the 2D polygon label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove 2D
tensorbay/label/label_polygon.py
Outdated
@@ -182,18 +182,18 @@ def dumps(self) -> Dict[str, Any]: # type: ignore[override] | |||
A dict containing all the information of the 2D polygon label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove 2D
tensorbay/label/catalog.py
Outdated
:class:`.Keypoints2DSubcatalog` subcatalog for 2D polygon type of label | ||
:class:`.Polygon2DSubcatalog` subcatalog for 2D polyline type of label | ||
:class:`.Keypoints2DSubcatalog` subcatalog for polygon type of label | ||
:class:`.PolygonSubcatalog` subcatalog for 2D polyline type of label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong order.
PR Closed: Graviti-AI#822
No description provided.