Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): validate AccessKey and display the user info in "gas auth" #848

Merged
merged 1 commit into from
Jul 22, 2021
Merged

feat(cli): validate AccessKey and display the user info in "gas auth" #848

merged 1 commit into from
Jul 22, 2021

Conversation

marshallmallows
Copy link
Collaborator

@marshallmallows marshallmallows commented Jul 22, 2021 •
edited
Loading

No description provided.

@marshallmallows marshallmallows requested a review from Lee-000 as a code owner July 22, 2021 05:52
@coveralls
Copy link

coveralls commented Jul 22, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1055734731

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.028%
Totals Coverage Status
Change from base Build 1055313775: 0.0%
Covered Lines: 5259
Relevant Lines: 6334
💛 - Coveralls

linjiX
linjiX requested changes Jul 22, 2021
View reviewed changes
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
Lee-000
Lee-000 requested changes Jul 22, 2021
View reviewed changes
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T16939_gas_auth_add_hint branch from ed56666 to 47a7889 Compare July 22, 2021 06:21
@marshallmallows marshallmallows changed the title refactor(cli): add examine for gas auth and amplify hints feat(cli): validate AccessKey and display the user info in "gas auth" Jul 22, 2021
@marshallmallows marshallmallows force-pushed the T16939_gas_auth_add_hint branch from 47a7889 to d120427 Compare July 22, 2021 06:31
linjiX
linjiX requested changes Jul 22, 2021
View reviewed changes
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
linjiX
linjiX requested changes Jul 22, 2021
View reviewed changes
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T16939_gas_auth_add_hint branch from d120427 to 6da7175 Compare July 22, 2021 07:07
@marshallmallows marshallmallows requested a review from linjiX July 22, 2021 07:07
Lee-000
Lee-000 requested changes Jul 22, 2021
View reviewed changes
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T16939_gas_auth_add_hint branch from 6da7175 to 8e9f33c Compare July 22, 2021 08:54
@marshallmallows marshallmallows requested a review from Lee-000 July 22, 2021 08:54
Lee-000
Lee-000 requested changes Jul 22, 2021
View reviewed changes
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T16939_gas_auth_add_hint branch from 8e9f33c to 062a348 Compare July 22, 2021 09:22
@marshallmallows marshallmallows requested a review from Lee-000 July 22, 2021 09:23
@marshallmallows marshallmallows force-pushed the T16939_gas_auth_add_hint branch from 062a348 to a52b547 Compare July 22, 2021 09:49
linjiX
linjiX requested changes Jul 22, 2021
View reviewed changes
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T16939_gas_auth_add_hint branch 3 times, most recently from d67fbac to 96bc849 Compare July 22, 2021 10:10
@marshallmallows marshallmallows force-pushed the T16939_gas_auth_add_hint branch from 96bc849 to e2895d9 Compare July 22, 2021 10:13
@marshallmallows marshallmallows merged commit 21570d1 into Graviti-AI:main Jul 22, 2021
@marshallmallows marshallmallows deleted the T16939_gas_auth_add_hint branch July 22, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-000 Lee-000 Lee-000 approved these changes

@linjiX linjiX linjiX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marshallmallows @coveralls @Lee-000 @linjiX