Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(exception): set all args except "message" as keyword args #916

Merged
merged 1 commit into from
Aug 12, 2021
Merged

refactor(exception): set all args except "message" as keyword args #916

merged 1 commit into from
Aug 12, 2021

Conversation

marshallmallows
Copy link
Collaborator

@marshallmallows marshallmallows commented Aug 10, 2021 •
edited
Loading

No description provided.

@coveralls
Copy link

coveralls commented Aug 10, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1123117915

  • 25 of 32 (78.13%) changed or added relevant lines in 4 files are covered.
  • 15 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 84.081%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tensorbay/client/requests.py 0 2 0.0%
tensorbay/client/status.py 0 2 0.0%
tensorbay/exception.py 24 27 88.89%
Files with Coverage Reduction New Missed Lines %
tensorbay/exception.py 15 63.64%
Totals Coverage Status
Change from base Build 1123112857: 0.1%
Covered Lines: 5514
Relevant Lines: 6558
💛 - Coveralls

@marshallmallows marshallmallows force-pushed the T17541_change_exception_parameter_type branch from 9daefc5 to 9d2fc46 Compare August 11, 2021 05:44
Lee-000
Lee-000 requested changes Aug 11, 2021
View reviewed changes
Copy link
Collaborator

@Lee-000 Lee-000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scope should be added as refactor(exception).

tensorbay/exception.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows changed the title refactor: set all args besides "message" as key args for exceptions refactor(exception): set all args besides "message" as key args Aug 11, 2021
@marshallmallows marshallmallows force-pushed the T17541_change_exception_parameter_type branch from 9d2fc46 to 9f7db20 Compare August 11, 2021 06:47
@marshallmallows marshallmallows force-pushed the T17541_change_exception_parameter_type branch from 9f7db20 to bc63cb5 Compare August 11, 2021 07:18
Lee-000
Lee-000 requested changes Aug 11, 2021
View reviewed changes
tensorbay/exception.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T17541_change_exception_parameter_type branch from bc63cb5 to 12e4c30 Compare August 11, 2021 09:08
@marshallmallows marshallmallows force-pushed the T17541_change_exception_parameter_type branch from 12e4c30 to 1aa12f1 Compare August 11, 2021 09:57
Lee-000
Lee-000 requested changes Aug 11, 2021
View reviewed changes
tensorbay/client/requests.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T17541_change_exception_parameter_type branch from 1aa12f1 to dacd2ff Compare August 12, 2021 02:25
Lee-000
Lee-000 requested changes Aug 12, 2021
View reviewed changes
tensorbay/exception.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T17541_change_exception_parameter_type branch from dacd2ff to 60496aa Compare August 12, 2021 03:54
@marshallmallows marshallmallows force-pushed the T17541_change_exception_parameter_type branch from 60496aa to 629e027 Compare August 12, 2021 04:14
@marshallmallows marshallmallows changed the title refactor(exception): set all args besides "message" as key args refactor(exception): set all args except "message" as keyword args Aug 12, 2021
@marshallmallows marshallmallows force-pushed the T17541_change_exception_parameter_type branch from 629e027 to 62b0525 Compare August 12, 2021 08:09
@marshallmallows marshallmallows merged commit 1afdc3b into Graviti-AI:main Aug 12, 2021
@marshallmallows marshallmallows deleted the T17541_change_exception_parameter_type branch August 12, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lee-000 Lee-000 Lee-000 approved these changes

@linjiX linjiX linjiX approved these changes

@rexzheng324-c rexzheng324-c rexzheng324-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marshallmallows @coveralls @Lee-000 @linjiX @rexzheng324-c