Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): catch the known custom exception and print error message #939

Merged
merged 1 commit into from
Aug 23, 2021
Merged

feat(cli): catch the known custom exception and print error message #939

merged 1 commit into from
Aug 23, 2021

Conversation

marshallmallows
Copy link
Collaborator

@marshallmallows marshallmallows commented Aug 17, 2021 •
edited
Loading

No description provided.

@coveralls
Copy link

coveralls commented Aug 17, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1157566176

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.391%
Totals Coverage Status
Change from base Build 1157326584: 0.0%
Covered Lines: 5563
Relevant Lines: 6671
💛 - Coveralls

@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch from f28aadd to 83fd1f4 Compare August 17, 2021 05:30
Lee-000
Lee-000 requested changes Aug 17, 2021
View reviewed changes
Copy link
Collaborator

@Lee-000 Lee-000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If debug is not enabled, the logger in client.request should be disabled.
  2. When InternalServerError occurred, the details of the request and response should be printed.

@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch from 83fd1f4 to 00e9be8 Compare August 18, 2021 02:26
Lee-000
Lee-000 requested changes Aug 18, 2021
View reviewed changes
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
tensorbay/cli/branch.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch from 00e9be8 to 5cce24c Compare August 18, 2021 06:15
Lee-000
Lee-000 requested changes Aug 18, 2021
View reviewed changes
tensorbay/cli/branch.py Outdated Show resolved Hide resolved
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch from 5cce24c to 4c049b8 Compare August 18, 2021 06:43
Lee-000
Lee-000 requested changes Aug 18, 2021
View reviewed changes
tensorbay/cli/branch.py Outdated Show resolved Hide resolved
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
tensorbay/cli/config.py Outdated Show resolved Hide resolved
tensorbay/cli/dataset.py Outdated Show resolved Hide resolved
tensorbay/cli/rm.py Outdated Show resolved Hide resolved
tensorbay/cli/branch.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch from 4c049b8 to 3a82027 Compare August 18, 2021 09:03
@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch 2 times, most recently from 68cd655 to 865922d Compare August 18, 2021 09:29
linjiX
linjiX requested changes Aug 18, 2021
View reviewed changes
tensorbay/cli/rm.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch 2 times, most recently from c81be1a to 0142adb Compare August 19, 2021 02:10
@marshallmallows marshallmallows requested a review from linjiX August 19, 2021 02:10
linjiX
linjiX requested changes Aug 19, 2021
View reviewed changes
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
linjiX
linjiX reviewed Aug 19, 2021
View reviewed changes
tensorbay/cli/log.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch from 0142adb to 7177e61 Compare August 19, 2021 09:05
@marshallmallows marshallmallows requested a review from linjiX August 19, 2021 09:05
linjiX
linjiX requested changes Aug 20, 2021
View reviewed changes
tensorbay/cli/auth.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch from 7177e61 to 8fa8f3b Compare August 20, 2021 10:00
linjiX
linjiX requested changes Aug 22, 2021
View reviewed changes
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
tensorbay/cli/utility.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch from 8fa8f3b to 24c476d Compare August 23, 2021 03:42
@marshallmallows marshallmallows requested a review from linjiX August 23, 2021 03:42
linjiX
linjiX requested changes Aug 23, 2021
View reviewed changes
tensorbay/cli/log.py Outdated Show resolved Hide resolved
@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch from 24c476d to df4d427 Compare August 23, 2021 06:17
@marshallmallows marshallmallows requested a review from linjiX August 23, 2021 06:17
@marshallmallows marshallmallows force-pushed the T15648_catch_exception_and_echo_error_message branch from df4d427 to aea7888 Compare August 23, 2021 06:40
@marshallmallows marshallmallows merged commit c3e1f82 into Graviti-AI:main Aug 23, 2021
@marshallmallows marshallmallows deleted the T15648_catch_exception_and_echo_error_message branch August 23, 2021 06:40
@linjiX linjiX mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linjiX linjiX linjiX approved these changes

@Lee-000 Lee-000 Lee-000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marshallmallows @coveralls @Lee-000 @linjiX