refactor(cli): unify the format of prompt messages in cli #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linjiX
requested changes
Aug 31, 2021
| branch_tbrn = TBRN(dataset_client.name, revision=name) | ||
| click.echo(f"{branch_tbrn} has been successfully created") | ||
| branch_tbrn = get_colored_tbrn(TBRN(dataset_client.name, revision=name)) | ||
| click.echo(f'Successfully created branch "{branch_tbrn}"') |
There was a problem hiding this comment.
shall we use past-tense here？
There was a problem hiding this comment.
It is more concise this way.
Pull Request Test Coverage Report for Build 1193747278
💛 - Coveralls |
Lee-000
force-pushed
the
T15660_cli_message
branch
from
06abb92 to
9141a74
Compare
Lee-000
force-pushed
the
T15660_cli_message
branch
from
9141a74 to
7c357a1
Compare
Lee-000
changed the title
linjiX
approved these changes
Sep 2, 2021
Lee-000
force-pushed
the
T15660_cli_message
branch
from
7c357a1 to
869375f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.