Functionality placeholders #1981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Related to #1980
This needs to be DRY'd and improved, but it's looking pretty good.
|
Starting to take shape:
|
Traits allow us to not add too much into the abstract plugin and theme hooks class. To make a class function as a placeholder, you add `use GravityView_Functionality_Placeholder;` then implement the abstract methods.
|
@zackkatz I'm unsure if it's included, but please don't forget to include the PDF for GravityView tab. |
|
@doekenorg Since you have recently worked on this for #1996, I think it makes sense if you were to work on the functionality. Let me know if you have questions. |
- Extracted a placeholder.php template - Replaced `add_placeholder_hooks` with a more generic `add_inactive_hooks` when the plugin is inactive. - Removed the trait and opted for a Placeholder value object - Added `extra_nav_class` option to a metabox for displaying purposes. - Added a `gk/navigation/tab` hook to overwrite the navigtaion label HTML. - Added hooks before and after a metabox for additional rendering purposes.
It looks better!
This handles multi-rule strings while also sanitizing
mrcasual
reviewed
Aug 8, 2024
assets/js/admin-views.js
Outdated
| const ajaxRoute = $( this ).data( 'action' ) + '_product'; | ||
| const text_domain = $( this ).data( 'text-domain' ); | ||
|
|
||
| // Todo: refactor after #1996 is merged. |
There was a problem hiding this comment.
@zackkatz or @doekenorg, what kind of refactoring is expected here?
There was a problem hiding this comment.
Good question! That's one for @doekenorg I believe.
There was a problem hiding this comment.
I think this has to do with code duplication when it comes to activating plugins. See if we can reuse the logic from that PR instead having it here again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1980
💾 Build file (729b388).