Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local timezone when formatting Time fields #2107

Merged

Conversation

mrcasual
Copy link
Collaborator

@mrcasual mrcasual commented Aug 13, 2024

This fixes #2102 and supports various time format characters, including escaped values and colons such as \a\t\ H\:i\:s (per our guide).

💾 Build file (07edb8b).

@mrcasual mrcasual self-assigned this Aug 13, 2024
Copy link
Contributor

@rafaehlers rafaehlers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixed it! ✅

Copy link
Member

@zackkatz zackkatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrcasual Only reviewed code, not functionality.

Is there a need to replace |COLON| back to :?

includes/class-gravityview-merge-tags.php Outdated Show resolved Hide resolved
includes/class-gravityview-merge-tags.php Outdated Show resolved Hide resolved
@mrcasual
Copy link
Collaborator Author

@mrcasual Only reviewed code, not functionality.

Is there a need to replace |COLON| back to :?

@zackkatz, it's not needed as the format is directly extracted without going through the parsing function as it was before.

@mrcasual mrcasual force-pushed the issue/2102-time-field-format-merge-tag-modifier-timezone branch from 2bcb4ce to 07edb8b Compare August 13, 2024 21:43
@mrcasual mrcasual merged commit 9632d66 into develop Aug 13, 2024
1 check passed
@mrcasual mrcasual deleted the issue/2102-time-field-format-merge-tag-modifier-timezone branch August 13, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:format Merge Tag modifier for time fields not considering website UTC
3 participants