Check if value has start and end dates #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mwalek, please test. |
|
@mrcasual I was not able to reproduce the issue without the fix. So I can't confirm that this is fixed. I tested without the solution and got the following error: After adding the solution (using this build), the warning no longer appears. If you can confirm that the problem is the same, then we can consider the issue resolved. Otherwise, please share additional details for reproducing the problem. ✔ Tested on PHP Version 7.4.30. |
|
@omarkasem, please see @Mwalek's response. |
…-in-search-widget-causes-fatal-error
|
I was able to reproduce it:
This PR fixed it ✅ |
mrcasual
deleted the
issue/2115-moving-from-date-to-date-range-in-search-widget-causes-fatal-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💾 Build file (fd80f29).