Add Configuration Option and Filter to mute Elasticsearch Deprecation Warnings #10239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dennisoelkers
requested changes
Mar 10, 2021
...rg/graylog/storage/elasticsearch7/ElasticsearchFilterDeprecationWarningsInterceptorTest.java
Outdated
Show resolved
Hide resolved
...va/org/graylog/storage/elasticsearch7/ElasticsearchFilterDeprecationWarningsInterceptor.java
Outdated
Show resolved
Hide resolved
janheise
changed the title
janheise
added a commit
that referenced
this pull request
Mar 25, 2021
… Warnings (#10239) * #10163 muting Elasticsearch deprecation warnings on responses * #10163 added config option/description to graylog.conf * #10163 Removed unfinished test * #10163 refactored interceptor into a class, added tests * added missing license headers * added a second filter message, changed assertions to the preferred format * added Joda related deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds an interceptor to HttpClient that filters deprecation warnings from the Http-response headers if the configuration option is set.
Fixes for #10163 and #9822
Motivation and Context
The Elasticsearch deprecation warnings might generate bloat in the logs that are not helpful.
How Has This Been Tested?
Manual tests and an automatic test class for a working case and for corner cases
Types of changes
Checklist: