Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to a repackaged and fixed version of java-grok #5800

Merged
merged 4 commits into from
Mar 26, 2019
Merged

Switch back to a repackaged and fixed version of java-grok #5800

merged 4 commits into from
Mar 26, 2019

Commits on Mar 25, 2019

  1. Switch back to a repackaged and fixed version of java-grok 

    To support underscores ("_") in Grok match group names, we had to modify
the java-grok library to use the old regexp engine again.

See: graylog-labs/java-grok#2

This also adds a test for the Grok extractor to make sure that using
underscores works.

Fixes #5704
Fixes #5563
    @bernd
    bernd committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    0979934 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. Fix GrokPatternService#extractPatternNames and add a test for it

    @bernd
    bernd committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    f87c068 View commit details
    Browse the repository at this point in the history

  2. Add missing license header to GrokPatternServiceTest

    @bernd
    bernd committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    f5ef99d View commit details
    Browse the repository at this point in the history

  3. Add test for named group with underscore 

    Prior to this change, there was no test for named groups
with underscores in the FunctionSnippetsTest

This change enhances the grok() test to run with a
named group with underscore.
    @kmerz
    kmerz committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    a04c255 View commit details
    Browse the repository at this point in the history