Fix window decorations being too wide #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daninator1
changed the title
|
Seems to work fine on macOS! |
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the window decorations being too wide after the switch to AppWindow.
After some investigating I found out that the MinWidth button style that was applied globally affected the custom implementation of the window decorations created by the FluentAvalonia library.
I therefore excluded these buttons from the style which fixes the issue while not affecting other parts of the UI where this MinWidth style may have been intended.
As a bonus, this also seems to fix the missing window tiling selector (or whatever it is called) on Windows 11 which should appear when hovering over the minimize/maximize button. For me, this was (almost always) broken until I applied this fix.
As I'm no expert regarding Avalonia, please feel free to let me know if you see any issues with this approach! 👍🏻
Additionally, I could only test this change on a Windows (11) machine, so if anyone else could confirm that this does not break the window decorations on macOS or Linux, that would be great!
Fixes #19