UI: Fix UpdateWaitWindow.axaml windows being too big on windows #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is currently an issue where to windows where it says "Installing firmware..." has no rounded corners
|
This needs testing to see if it breaks the window on Linux. You can test by installing firmware or extracting romfs, exefs or icon and looking at the window that pops up for a small second. This is nowhere near as important as jitsparse or custom "vsync" and doesn't need a lot of testing, even just one or two linux testers will do. |
|
Looks good on linux x64
|
|
That's not the windows i'm talking about, i'm actually talking about the window that shows up for a bit after you press "Yes" on that window. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the window that appears for a bit while installing firmware being too big on windows ( my testing shows that this issue does not happen on macos ).