-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/organization logo #1041
base: master
Are you sure you want to change the base?
Conversation
…ng to an organization
…h an organization is logged in
…f user has an organization
…ng to an organization
…h an organization is logged in
…f user has an organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @spomberg, just one suggestion.
@sebastiangaertner Is this what you had in mind?
Do we enforce any kind of size restrictions on org logos?
@nmcharlton can we make it svg mandatory then the size is flexible or would it just read the stakeholder logo url? |
@sebastiangaertner How do org logos get into the system? Do orgs send them to us based on some requirement? The issue is that if we're directly replacing a wide, rectangular Greenstand logo with a square organization logo, it doesn't really fit in the space in the same way. |
Description
Displays the organization logo instead of Greenstand's if the user belongs to an organization with a logo URL available.
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
Currently, Greenstand's logo is displayed on the navbar and on the menu no matter what.
What is the new behavior?
Implemented a logoPath state that serves as the image source in the IconLogo component, once the user logs in, a request is made to retrieve the organization's logo URL, if there is one available the state will be set to that path so the organization logo is displayed on the navbar and menu instead of Greenstand's. If the user is logged out the logoPath state defaults to Greenstand's logo.
Breaking change
Does this PR introduce a breaking change?
No