Matched captures statistic #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kpoke
requested changes
Jul 25, 2023
| @@ -2,8 +2,8 @@ const BaseRepository = require('./BaseRepository'); | |||
|
|
|||
| class CaptureRepository extends BaseRepository { | |||
| constructor(session) { | |||
| super('capture_denormalized', session); | |||
| this._tableName = 'capture_denormalized'; | |||
| super('reporting.capture_denormalized', session); | |||
There was a problem hiding this comment.
You should remove the 'reporting.'. In the cloud, the DATABASE_URL is already configured only to access the reporting schema, so this is unnecessary. This might also be the reason for the failed tests
There was a problem hiding this comment.
Ah, my bad. I thought I committed the code without the reporting. prefix.
| @@ -55,6 +55,7 @@ class CaptureRepository extends BaseRepository { | |||
| const whereBuilder = function (object, builder) { | |||
| const result = builder; | |||
| const filterObject = { ...object }; | |||
| console.log('FILTEROBJ', filterObject) | |||
There was a problem hiding this comment.
you can remove the console.log
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new reporting card statistic for matched captures is implemented.
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfils these requirements
Issue
What is the current behavior?
There is no matched captures statistic.
What is the new behavior?
The
capture/statisticsandcapture/statistics/card?card_title=matched_capturesendpoints returnmatched_capturesstatistic.Breaking change
Does this PR introduce a breaking change?
No.
Other useful information
The image for new behavior is based on test data. The
capture_denormalizedtable needs to be populated using an Airflow task, which is not yet updated.