Reset filters button #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pages/MyTransfers/TableFilters.js
OlhaD
reviewed
Aug 21, 2023
| return ( | ||
| <FilterResetButton | ||
| onClick={() => setFilter(defaultFilter)} | ||
| type='submit' |
There was a problem hiding this comment.
Maybe it should be 'button' instead as there is no form data to submit
OlhaD
reviewed
Aug 21, 2023
|
|
||
| export const FilterResetButton = styled(Button)({ | ||
| color: '#fff', | ||
| height: '40px', |
There was a problem hiding this comment.
I see that you mostly use px in a markup, and it is maybe not a problem here as it is a small button, but I would suggest using relative units instead like rem, so it would look similar on different scales.
There was a problem hiding this comment.
I believe the reset button is typically found on the right-hand side of the filters. Anyway, the design of the filters will most likely be changed in V2, but if it is not a problem, I would move this button to the right.
OlhaD
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A button to reset My Transfer table filters is implemented.
Issue(s) addressed
What kind of change(s) does this PR introduce?
Please check if the PR fulfills these requirements
Issue
What is the current behavior?
Currently, there is no way to reset the table filters without manually changing the values.
What is the new behavior?
Breaking change
Does this PR introduce a breaking change?
No.
Other useful information
None.