feat: refactor getTokenByTransferId to using join SQL

server/repositories/TokenRepository.js

@@ -21,6 +21,19 @@ class TokenRepository extends BaseRepository{
     return result;
   }
 
+  /*
+   * select transaction table by transfer id, return matched tokens
+   */
+  async getByTransferId(transferId){
+    const result = await this._session.getDB().raw(`
+      SELECT "token".* FROM "token"
+      JOIN "transaction" 
+      ON "token".id = "transaction".token_id
+      WHERE "transaction".transfer_id = '226f76cd-52b0-486b-b58a-98230696c748'
+    `);
+    return result;
+  }
+
 }
 
 module.exports = TokenRepository;

server/repositories/TokenRepository.spec.js

@@ -29,4 +29,13 @@ describe("TokenRepository", () => {
     expect(token).property("token").eq("testUuid");
   });
 
+  it("getByTransferId", async () => {
+    tracker.on("query", (query) => {
+      expect(query.sql).match(/select.*token.*transaction.*transfer_id/is);
+      query.response([{id:1, token: "testUuid"}]);
+    });
+    const tokens = await tokenRepository.getByTransferId("testUuid");
+    expect(tokens).lengthOf(1);
+  });
+
 });

server/services/TokenService.js

@@ -87,12 +87,10 @@ class TokenService{
   }
 
   async getTokensByTransferId(transferId){
-    const result = await this.transactionRepository.getByFilter({
-      transfer_id: transferId,
-    });
+    const result = await this.tokenRepository.getByTransferId(transferId);
     const tokens = [];
     for(const r of result){
-      const token = await this.getById(r.token_id);
+      const token = new Token(r);
       tokens.push(token);
     }
     return tokens;

server/services/TokenService.spec.js

@@ -96,22 +96,11 @@ describe("Token", () => {
   describe("getTokensByTransferId", () => {
 
     it("Successfuly", async () => {
-      const tokenId1 = uuid.v4();
       const tokenId2 = uuid.v4();
       const transferId1 = uuid.v4();
-      const transactionId1 = uuid.v4();
-      const token = new Token({id:tokenId2});
-      const transaction = {
-        id: transactionId1,
-        token_id: tokenId2,
-      };
-      const fn = sinon.stub(TransactionRepository.prototype, "getByFilter").resolves([transaction]);
-      const fn2 = sinon.stub(TokenService.prototype, "getById").resolves(token);
+      const fn = sinon.stub(TokenRepository.prototype, "getByTransferId").resolves([{id:tokenId2}]);
       const tokens = await tokenService.getTokensByTransferId(transferId1);
-      expect(fn).calledWith({
-        transfer_id: transferId1,
-      })
-      expect(fn2).calledWith(tokenId2);
+      expect(fn).calledWith(transferId1);
       expect(tokens).lengthOf(1);
     });
   });