Impact value #233
Open
Impact value #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadiorchen
commented
Jun 2, 2021
Comment on lines
+974
to
+976
| impact_value_transfered: | ||
| type: integer | ||
| description: 'The number of impact valued that has been actually transfered, this field is just valid when the transfer request type is setting impact value as the parameter' |
There was a problem hiding this comment.
@ZavenArra For the impact value transfer, I added the field called impact_value_transfered in the response, to indicate the actual impact value has been transferred in the transfer operation.
Also, I will return this field in the accept and fulfill endpoint if needed.
What do you think?
There was a problem hiding this comment.
And @ZavenArra another question, should we need to set the value_matrix_id parameter for the impact value transfer?
add impact value, test
add token.value field test can accept transfer requesting imapce value
can accept the pending transfer
…n-trading-api into impact-value
|
New commit resolve #242 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.