451 wallets make sortable 2 #453
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kpoke
requested changes
Jan 24, 2024
| @@ -4,6 +4,8 @@ const TrustRelationshipEnums = require('../../utils/trust-enums'); | |||
| const walletGetQuerySchema = Joi.object({ | |||
| limit: Joi.number().required(), | |||
| offset: Joi.number().integer(), | |||
| sortField: Joi.string(), | |||
| sortOrder: Joi.string(), | |||
There was a problem hiding this comment.
let's make this restricted to asc and desc
There was a problem hiding this comment.
@OlhaD It may be better to rename these to sort_by and order, to match with the current version of the API, which already has these options implemented.
Also, this PR should be merged into the production branch v1.10, right?
The current version doesn't support sorting by token amount either, so we should create an issue for that as well.
|
There are merge conflicts cc: @OlhaD |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add sorting to 'get wallets' API
What kind of change(s) does this PR introduce?