Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make changes based on comments of #481 #483

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

yunchipang
Copy link
Contributor

@yunchipang yunchipang commented Sep 18, 2024

Description

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfils these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?

What is the new behavior?

Breaking change

Does this PR introduce a breaking change?

Other useful information

@yunchipang
Copy link
Contributor Author

yunchipang commented Sep 19, 2024

Screenshot 2024-09-18 at 9 02 56 PM @Kpoke i set sync to false (as mentioned in #475) and added a migration to solve the issue. please let me know if there's any other concerns. tysm!

@Kpoke Kpoke merged commit 86d3143 into Greenstand:typescript-branch Oct 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants