Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable backend search functionality #489

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Conversation

samwel141
Copy link
Collaborator

Description

Added search feature in backend

Issue(s) addressed

  • Resolves #

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfils these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?
No backend search feature
What is the new behavior?
Can search wallet trust relationships from the backend using originator, target and initiator wallet name

Breaking change

No breaking change

Other useful information

@dadiorchen
Copy link
Collaborator

@samwel141 I think if you can add an integration test (test under tests folder) to cover this feature, it would be great, at the end of the day, integration is the last defense line for code quality.
Do think it is easy to write a int test?

@samwel141
Copy link
Collaborator Author

Yes, I have added the integration test for search functionality. check

Copy link
Collaborator

@dadiorchen dadiorchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samwel141 so quick! great job!

__tests__/trust-relationship-api.spec.js Outdated Show resolved Hide resolved
@samwel141 samwel141 requested a review from Kpoke as a code owner October 22, 2024 18:27
@Kpoke Kpoke merged commit e32844f into Greenstand:master Oct 29, 2024
1 check passed
Copy link

🎉 This PR is included in version 1.40.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants