Update utils.js #1660
Open
Update utils.js #1660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walletid not match redirect 404 Greenstand#1546
dadiorchen
reviewed
Jun 29, 2023
| @@ -231,7 +231,7 @@ const wrapper = (callback) => (params) => | |||
| if (e.response?.status === 404) return { notFound: true }; | |||
| return { | |||
| redirect: { | |||
| destination: '/500', | |||
| destination: '/404', | |||
There was a problem hiding this comment.
When I re-think this change, I think it is problematic, the previous logic is:
- If the status code is 404, then return notFound, which means 404 page.
- If any other case, return 500, means, unknown internal error
So I think we shouldn't make all error 404, that's confusing.
Back the the issue, the URL return 500 but 404, I thought this is because of some 500 error in the server side, but it is 404, so we need to debug the specific URL to see what happened, and handle that error then throw 404 to the wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Walletid not match redirect 404 #1546
Fixes # (issue)
#1546