Finding a bug #2549 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* v0 for glossary * add terms page /w basic terms navigation * `<TermsNavigationDesktop>` & `<TermsNavigationMobile>` * WIP: add desktop navigation * feat(glossary): implement glossary page and related components - UI: Add `faq`, `takeaway` & `relatedTerms` components (_faq.tsx, takeaways.tsx, page.tsx) - shadcn: Added new UI components (badge.tsx, card.tsx) - Updated content collections (content-collections.ts) for more frontmatter schema on glossary (reviewed by, takeaways, faq, etc.) - Add glossary content (check `mime-types.mdx`) for mocking - Update related configurations and utilities * [autofix.ci] apply automated fixes * remove twitter image from glossary * remove `api-design` entry * fix build by removing opengraph image and the image from glossary entries * empoty states, search functionality, updated glossary cards * remove `template` components in the glossary * Merge branch 'main' of https://github.com/unkeyed/unkey into richard/glossary * Update apps/www/content/glossary/mime-types.mdx Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * clean up * last change * fix types * remove `reviewedby` * `pnpm fmt` --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolves a bug in the Root Keys tab within the settings page of the Unkey app, where an error occurred upon visiting the tab. The issue was documented in Issue #2549. This fix ensures the Root Keys tab is accessible without triggering errors, improving user experience in the settings.
Fixes unkeyed#2549
Type of change
How should this be tested?
Checklist
pnpm buildpnpm fmtconsole.logsgit pull origin main