Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ender Link System #328

Closed
wants to merge 30 commits into from
Closed

Ender Link System #328

wants to merge 30 commits into from

Conversation

mikerooni
Copy link
Member

@mikerooni mikerooni commented Aug 27, 2023

The new Ender Link system, expanded with some new features (controllers, item transfer capability, multiple tiers, etc.).

ToDo List:

  • Add ender fluid link cover, controller multiblock (with tiers) and linking card
  • Add ender item link cover
  • Add editable UI to the covers and controller / rework prototype UI
  • Implement connecting covers to controller (also match controller UUID, stored on linking card)
  • Implement virtual item & fluid transfer (proxy the storage of all covers on that channel)
  • Implement linking multiple controllers (ensure that 2 channels are available per new controller in the network)
  • Add multiple tiers for the covers
  • Implement computing integration when 2.7 is merged
  • Implement cross dimension networks
  • Recipes and balancing
  • Documentation

@mikerooni mikerooni requested a review from a team as a code owner August 27, 2023 21:50
@mikerooni mikerooni marked this pull request as draft August 27, 2023 21:50
@mikerooni
Copy link
Member Author

mikerooni commented Aug 31, 2023

More TODOs as of the last push:

  • Add linking cards to drops on both covers and controller
  • Fix cards not being loaded initially (currently needs reinserting the card to be loaded, probably because of @Persisted handling)
  • Check if it's possible to make TransferType a registry instead of an enum
  • Consider transfer rate limit (requires moving the transfer logic to the controller and/or rate limiting the cover's returned transfer)
  • Implement channel selection in cover UI
  • Adapt channel count & range to tier
  • Implement range restrictions between controller and covers
  • Implement filtering
  • Add remaining tiers for controllers

@mikerooni mikerooni mentioned this pull request Sep 4, 2023
25 tasks
# Conflicts:
#	common/src/main/java/com/gregtechceu/gtceu/api/registry/GTRegistries.java
@mikerooni
Copy link
Member Author

  • Potential rework necessary for ProxiedTransferWrapper and transfer logic to better support IO type BOTH

Possible implementation - Transfer in two distinct steps:

  1. Move everything from IO.IN to IO.OUT and then IO.BOTH
  2. Move everything from IO.BOTH to IO.OUT only

Copy link
Member

@stanieldev stanieldev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM currently, lmk if you want approval (lots of merging we'll have to do lolol)

@mikerooni
Copy link
Member Author

I'm closing this one for now - in favor of starting over, if I work on it in the future ^^

Additions to revisit and possibly add to the current codebase:

@mikerooni mikerooni closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants