-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ender Link System #328
Closed
Closed
Ender Link System #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikerooni
force-pushed
the
mi-ender-link
branch
from
August 28, 2023 11:24
71625ef
to
feba9ce
Compare
More TODOs as of the last push:
|
Note: There is currently no transfer logic in the EnderFluidLinkCover. This will be reimplemented, but centralized in the controller.
mikerooni
force-pushed
the
mi-ender-link
branch
from
September 3, 2023 15:45
c8f2cfd
to
973ab0a
Compare
# Conflicts: # common/src/main/java/com/gregtechceu/gtceu/api/registry/GTRegistries.java
Possible implementation - Transfer in two distinct steps:
|
stanieldev
reviewed
Nov 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM currently, lmk if you want approval (lots of merging we'll have to do lolol)
I'm closing this one for now - in favor of starting over, if I work on it in the future ^^ Additions to revisit and possibly add to the current codebase: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Ender Link system, expanded with some new features (controllers, item transfer capability, multiple tiers, etc.).
ToDo List: