Add Maintenance and Mufflers #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenibyss
reviewed
Aug 29, 2021
src/main/java/gregtech/api/metatileentity/multiblock/MultiblockAbility.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/multiblock/MultiblockWithDisplayBase.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/multiblock/MultiblockWithDisplayBase.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/multiblock/RecipeMapMultiblockController.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * This class is used for handling GT tool types instead of specific tools | ||
| */ | ||
| public class GTToolTypes { |
There was a problem hiding this comment.
Could these be moved into GTValues maybe? Or is that too early to call these (i.e., they end up null)?
...in/java/gregtech/common/metatileentities/multi/electric/MetaTileEntityDistillationTower.java
Outdated
Show resolved
Hide resolved
serenibyss
reviewed
Aug 29, 2021
...ch/common/metatileentities/multi/electric/generator/MetaTileEntityLargeCombustionEngine.java
Outdated
Show resolved
Hide resolved
serenibyss
approved these changes
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR adds maintenance and muffler mechanics the same way as implemented in Gregicality. Maintenance Hatches have a config which will fully remove themselves from structure requirements, while Muffler Hatches do not.
How solved:
New hatches were added, in addition to changes made to the multiblock classes.
Outcome:
Added Maintenance and Muffler Hatch Mechanics.
Additional info:
The Large Combustion Engine occasionally shuts itself off until the controller is broken and replaced. The cause is unknown, but will most likely be resolved when the rewrite for it takes place. The Large Gas Turbine does not emit smoke particles from its muffler. The cause is most likely rooted very deep into the class, and will be better fixed when the rewrite for it takes place.