Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops the Low energy status showing when there is enough energy. #136

Closed
wants to merge 3 commits into from

Conversation

htmlcsjs
Copy link
Member

@htmlcsjs htmlcsjs commented Sep 5, 2021

What:
Stops the Low energy status showing when there is enough energy

How solved:
When there is enough energy for a recipe reset the variable. The function used to get the energy status in UI only updates its return value to prevent flickering.

Outcome:
Stops the Low energy status showing when there is enough energy.

@Syrcan
Copy link
Contributor

Syrcan commented Sep 5, 2021

I like the fact that it updates once per second to avoid flickering, but your implementation makes it a coin flip. If you have a machine running 30eu/t and supplied with exactly 15eu/t, it may say there are no issues whatsoever depending on which side of the coin you are.

Interestingly enough, I like the fact that my machines warn me about low power even after it's resolved. It gives me an indication something went wrong at some point.
I think a good compromise would be to give machines and multiblocks another display for TOP to indicate power was low at some point during the recipe.

@serenibyss
Copy link
Member

As Syrcan indicated, this can still easily cause a flickering indicator. I think this may need to be done with some sort of EU per second tracking, so that we can determine if the average across some length of time is too low instead of using an instantaneous value

@Yefancy
Copy link
Contributor

Yefancy commented Nov 19, 2021

flickering indicator and status of the energy problem have been fixed in #196 2a43b64.
Based on the api that input eu/s. However, the steam machine has no corresponding API, working as before

@Yefancy Yefancy closed this Nov 19, 2021
@htmlcsjs htmlcsjs deleted the BetterLowPower branch December 7, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants