MUI cover skeleton and Machine Controller Cover port #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechLord22
reviewed
Dec 21, 2023
Comment on lines
+115
to
+125
| default <T extends Enum<T>> BoolValue.Dynamic boolValueOf(EnumSyncValue<T> syncValue, T value) { | ||
| return new BoolValue.Dynamic(() -> syncValue.getValue() == value, $ -> syncValue.setValue(value)); | ||
| } | ||
|
|
||
| /** | ||
| * Get a BoolValue for use with toggle buttons which are "linked together," | ||
| * meaning only one of them can be pressed at a time. | ||
| */ | ||
| default BoolValue.Dynamic boolValueOf(IntSyncValue syncValue, int value) { | ||
| return new BoolValue.Dynamic(() -> syncValue.getValue() == value, $ -> syncValue.setValue(value)); | ||
| } |
There was a problem hiding this comment.
These should probably move to a general MUI2 utils class instead, and also be made static.
| @@ -268,6 +270,19 @@ public static class IDs { | |||
| .canApplyTheme() | |||
| .build(); | |||
|
|
|||
| public static final UITexture MC_BUTTON = new UITexture.Builder() | |||
| .location("modularui", "gui/widgets/mc_button.png") // todo | |||
There was a problem hiding this comment.
What needs addressing for this todo and the one for the disabled button?
There was a problem hiding this comment.
Technically could be nothing, but I left the todo since its using a texture file from MUI that we might want to just copy over to GT for stability/later modification
| public void writeInitialSyncData(@NotNull PacketBuffer packetBuffer) { | ||
| super.writeInitialSyncData(packetBuffer); | ||
| packetBuffer.writeBoolean(isInverted); | ||
| packetBuffer.writeShort(controllerMode.ordinal()); |
There was a problem hiding this comment.
This can be written and read from as a byte instead of short.
| @@ -1300,18 +1300,19 @@ cover.fluid_regulator.transfer_mode.description=§eTransfer Any§r - in this mod | |||
| cover.fluid_regulator.supply_exact=Supply Exact: %s | |||
| cover.fluid_regulator.keep_exact=Keep Exact: %s | |||
|
|
|||
| cover.machine_controller.title=Machine Controller Settings | |||
| cover.machine_controller.normal=Normal | |||
There was a problem hiding this comment.
This lang entry is used in some other covers, like the Advanced Energy Detector. So removing it causes there to be a missing lang entry for that cover.
ALongStringOfNumbers
approved these changes
Dec 29, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoverWithUIfor creating similar looking cover UIsTwo API fixes/changes:
holder.addCover()andcover.onAttachment()so thatonAttachment()can set up some state that can then properly sync to the client for initial stategetStackForm()method ontoCoverableView. Technically breaking but who is actually implementing this interface alreadyMachine Controller Cover