Rework AbstractRecipeLogic #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TechLord22
force-pushed
the
abstractlogic-rework
branch
2 times, most recently
from
5f38a61 to
e5b8db7
Compare
serenibyss
added
the
status: high priority
Yefancy
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
I tested it in the game and felt it worked the same as before. The changes are mostly to decouple, which looks good. If I have to say something that getRecipeMap() doesn't seem to be overridden either. It's a final field, so accessing the recipeMap directly I think is ok with the design specification.
|
The reason for |
serenibyss
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits apart AbstractRecipeLogic into many more specialized methods, to allow for more fine-tuned control of machine behavior. The goal was to allow more core operations to be left intact without the need for any copy pasting, while allowing changes to still happen as freely as possible.
The PR also updates many RecipeLogics to use the new methods for cleanliness, including the EBF, Multismelter, Fusion Reactor, and Gas Collector.