Fix Stocking Buses running recipes while offline #2608
Merged
+36
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ALongStringOfNumbers
added
type: bug
TechLord22
approved these changes
Sep 7, 2024
IntegerLimit
reviewed
Sep 9, 2024
There was a problem hiding this comment.
If offline, wouldn't it just be simpler and cleaner to clear the item slots instead of performing a full refresh, such as its done in Labs?
ALongStringOfNumbers
force-pushed
the
alson-stocking-fix
branch
from
1f000c2
to
8247a2f
Compare
TechLord22
approved these changes
Nov 10, 2024
| // Immediately clear cached items if the status changed, to prevent running recipes while offline | ||
| if (this.meStatusChanged && !this.isOnline) { | ||
| if (autoPull) { | ||
| clearInventory(0); |
There was a problem hiding this comment.
Can this use getAEItemHandler().clearConfig()? If so maybe this and other occurrences of clearInventory(0) should move to it.
There was a problem hiding this comment.
They do basically the same thing, so I don't see a particular reason to switch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes Stocking buses/hatches running recipes while they are offline.
Closes #2559
Implementation Details
Immediately resync the inventory if the online status of the network changes
Outcome
Fixes Stocking buses being able to provide inputs to multiblocks while they are offline.