-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the patterning #2689
Draft
vrejhead
wants to merge
64
commits into
GregTechCEu:master
Choose a base branch
from
vrejhead:the-patterning
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
the patterning #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghzdude
reviewed
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just quickly looked through and noticed some stuff
also i think it might be better if the strings were all lowercase, and ensuring all passed in strings are lowercase
src/main/java/gregtech/api/metatileentity/multiblock/IMultiblockPart.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/multiblock/MultiblockControllerBase.java
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/multiblock/MultiblockControllerBase.java
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/multiblock/MultiblockControllerBase.java
Outdated
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/multiblock/IMultiblockPart.java
Show resolved
Hide resolved
src/main/java/gregtech/api/metatileentity/multiblock/MultiblockControllerBase.java
Outdated
Show resolved
Hide resolved
ghzdude
reviewed
Dec 26, 2024
src/main/java/gregtech/api/metatileentity/multiblock/MultiblockControllerBase.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Rewrote the entire multiblock pattern system.
Implementation Details
BlockPattern
now implementsIBlockPattern
for general pattern stuff, so does the newExpandablePattern
which makes cleanroom and charcoal pile igniter sane.PatternMatchContext
andMultiblockShapeInfo
are now useless/deleted. The multiblock builder now has a gui that allows one to configure the parameters of autobuild, and so can the multiblock if it wants. Previews now use the autobuild system, where they supply an iterator of maps to autobuild the multiblock with. Multiblock part sharing now only works within the same multiblock class and substructure(yeah substructures exist now, so a controller can have multiple patterns).RelativeDirection
has been reworked to have not terrible code, andGreggyBlockPos
now exists as a sane alternative toMutableBlockPos
. There is probably something I missed but that's hopefully the most important stuff.Outcome
less kila code
Additional Information
The vacuum freezer and large chemical reactor has "new structures" for testing purposes, so yeah. I'll change them back when the pr is ready to merge.
Potential Compatibility Issues
There's zero backwards compat for addons, my bad .
But if addons update properly, then a player's world should still function, ie a multi running a recipe before the update will not void the recipe but instead continue it after the update. Most importantly because for some reason the old front facing was reversed in structure checking code, addons need to flip all their structures across the relative left-right and front-back axis(since relative up-down isn't affected when relative front-back got reversed). A lot of methods that don't use substructure name are deprecated(but still work) and addons should update them to use the new methods as well.