lock: change locking to a mutex #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutexes have the advantage that they allow for blocking waits natively. These are typically handled by some external sync mechanism. Thusly, threads will be put to sleep by the OS until the other place has unlocked it. The old atomic-bool solution required a busy-wait to achieve this. This changed implementation has the disadvantage that it requires rustc version >= 1.70.0 which, as of commiting this, still is in beta. However OnceLock avoids having to pull in once_cell or lazy_static as dependencies. So i think its best to wait until june and then merge this.
|
Sorry for the super late response, I missed the notification somehow. I don't really know a lot about the lower level details, but it sounds like it makes sense! And by now everything needed is stable, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest changing the locking mechanism behind SpiceLock to a mutex.
Mutexes have the advantage that they allow for blocking waits natively. These are typically handled by some external sync mechanism. Thusly, threads will be put to sleep by the OS until the other place has unlocked it.
The old atomic-bool solution required a busy-wait to achieve this.
This changed implementation has the disadvantage that it requires rustc version >= 1.70.0 which, as of commiting this, still is in beta (it is stabilized however, so its just a small wait, not an indeterminate one!) . However OnceLock avoids having to pull in once_cell or lazy_static as dependencies. So i think its best to wait until june to merge this.
Have a great week!
EDIT: Oh and since you did the original legwork, what are your thoughts on this @mclrc ?
~mkalte