Add georec, mxv, radrec, spkezr, vcrss, vdot, xpose #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Many thanks @s-rah for your feedback, your advice, and your precious time contributing to I'm taking note of your reply and will try my best to deliver a script to automatise the download of kernels to be used in the tests. If you've another idea for the test's assets packaging, I'm taking them! Please note all of this PR and contributions is still new to me, I've done the merge using Thank you again, and I wish you the best :) |
GregoireHENRY
referenced
this pull request
Sep 13, 2021
Merge `pr/2` from `@s-rah:main` into `@GregoireHENRY:dev`, after a first `pr/1`. It contains one commit: `254f7aaf15e9dd2a8fcb104c8341df6d6b99c2a1`, that "Add georec, mxv, radrec, spkezr, vcrss, vdot, xpose". From this pull-request, it required few more changes before acceptations, visible in the following commits: - `cbb6e405ffc73aac2b6c1c02c3c1e5eee95cd1dd`: that "Update HERA kernels" - `5c9ff3fd6a4f12822f5d7c3a7c43c38c7bf0f4da`: that "Change asset's path in tests" - `d02e09ad4014c8c1a635fb3fead1e5895bfdcd80`: that "Fix test function name"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested, this is now based on
devinstead ofmainNote: The
devbranch contains a few tests (likekdata()) which directly reference/home/greg/doc/krn/hera/mk/hera_study_PO_EMA_2024.tmso I wasn't able to run those specific tests as-is.