Fix CI: update php-cs-fixer (#106)

* Fix CI: update php-cs-fixer

* Update chromedriver to version 88.0.4324.96

* Use dbrekelmans/bdi to detect drivers

.github/CONTRIBUTING.md

@@ -168,6 +168,12 @@ http://127.0.0.1:9080
 http://127.0.0.1:9080/docusign/authorization_code/embedded_auth_code
 http://127.0.0.1:9080/docusign/authorization_code/remote_auth_code
 
+Detect and download the browser drivers automatically:
+
+```shell
+vendor/bin/bdi detect drivers
+```
+
 Then, run the following command to execute e2e tests:
 
 ```shell

.github/workflows/ci.yml

@@ -115,6 +115,7 @@ jobs:
         run: |
           mkdir -p build/screenshots build/logs/phpunit
           openssl aes-256-cbc -d -a -pbkdf2 -salt -in features/var/jwt/docusign.pem.enc -out features/var/jwt/docusign.pem -pass env:DOCUSIGN_RSA_PASSPHRASE
+          vendor/bin/bdi detect drivers
 
       - name: Run PHPUnit tests with coverage
         if: matrix.coverage

.gitignore

@@ -12,3 +12,4 @@
 /features/.env.*
 !features/var/storage/dummy.pdf
 /completed.pdf
+/drivers/

composer.json

@@ -43,6 +43,7 @@
         "webmozart/assert": "^1.5"
     },
     "require-dev": {
+        "dbrekelmans/bdi": "^0.3.0",
         "doctrine/annotations": "^1.11",
         "league/flysystem-bundle": "^1.2",
         "nyholm/symfony-bundle-test": "dev-master",

phpunit.xml.dist

@@ -10,7 +10,7 @@
         <env name="KERNEL_CLASS" value="DocusignBundle\E2e\Kernel" />
         <env name="SYMFONY_PHPUNIT_VERSION" value="9.4" />
         <server name="PANTHER_WEB_SERVER_DIR" value="./features/public/" />
-        <server name="PANTHER_CHROME_DRIVER_BINARY" value="./tests/config/chromedriver" />
+        <server name="PANTHER_CHROME_DRIVER_BINARY" value="./drivers/chromedriver" />
         <server name="PANTHER_NO_SANDBOX" value="1" />
     </php>
 

src/Controller/Callback.php

@@ -23,9 +23,8 @@
 
 final class Callback implements TranslatorAwareInterface
 {
-    public const EVENT_COMPLETE = 'signing_complete';
-
     use TranslatorAwareTrait;
+    public const EVENT_COMPLETE = 'signing_complete';
 
     public function __invoke(Request $request, EventDispatcherInterface $eventDispatcher): Response
     {

src/DependencyInjection/Configuration.php

@@ -158,7 +158,7 @@ public function getConfigTreeBuilder(): TreeBuilder
                                 ->validate()
                                     ->ifString()
                                     ->then(static function ($v) {
-                                        @trigger_error('The "grant_type" configuration key has been deprecated since 5.3.0 and will be removed in 6.0. Implicit authentication should not be used in this bundle.', E_USER_DEPRECATED);
+                                        @trigger_error('The "grant_type" configuration key has been deprecated since 5.3.0 and will be removed in 6.0. Implicit authentication should not be used in this bundle.', \E_USER_DEPRECATED);
 
                                         return $v;
                                     })

src/DependencyInjection/DocusignExtension.php

@@ -89,7 +89,7 @@ public function load(array $configs, ContainerBuilder $container): void
             // Clickwrap mode
             if (EnvelopeBuilder::MODE_CLICKWRAP === $value['mode']) {
                 $clickwrapExtensionDefinition->addMethodCall('addConfig', [$name, $value['demo'], [
-                    'environment' => pathinfo($value['api_uri'], PATHINFO_DIRNAME),
+                    'environment' => pathinfo($value['api_uri'], \PATHINFO_DIRNAME),
                     'accountId' => $value['auth_clickwrap']['api_account_id'],
                     'clientUserId' => $value['auth_clickwrap']['user_guid'],
                     'clickwrapId' => $value['auth_clickwrap']['clickwrap_id'],

src/EnvelopeCreator/DefineEnvelope.php

@@ -24,9 +24,8 @@
 
 final class DefineEnvelope implements EnvelopeBuilderCallableInterface, TranslatorAwareInterface
 {
-    public const EMAIL_SUBJECT = 'Please sign this document';
-
     use TranslatorAwareTrait;
+    public const EMAIL_SUBJECT = 'Please sign this document';
 
     private $router;
     private $envelopeBuilder;

src/EnvelopeCreator/GetViewUrl.php

@@ -19,7 +19,7 @@
 use DocusignBundle\Utils\CallbackRouteGenerator;
 use Symfony\Component\Routing\RouterInterface;
 
-/*final */class GetViewUrl implements EnvelopeBuilderCallableInterface
+/*final */ class GetViewUrl implements EnvelopeBuilderCallableInterface
 {
     private $router;
     private $envelopeBuilder;

src/Grant/JwtGrant.php

@@ -88,7 +88,7 @@ private function createToken(): string
                 ->relatedTo($this->userGuid) // sub
                 ->issuedAt($time) // iat
                 ->expiresAt($time->modify("$this->ttl sec")) // exp
-                ->permittedFor(parse_url($this->accountApiUri, PHP_URL_HOST)) // aud
+                ->permittedFor(parse_url($this->accountApiUri, \PHP_URL_HOST)) // aud
                 ->withClaim('scope', 'signature impersonation') // scope
                 ->getToken($config->signer(), $config->signingKey())
                 ->toString();
@@ -101,7 +101,7 @@ private function createToken(): string
             ->relatedTo($this->userGuid) // sub
             ->issuedAt($time) // iat
             ->expiresAt($time + $this->ttl) // exp
-            ->permittedFor(parse_url($this->accountApiUri, PHP_URL_HOST)) // aud
+            ->permittedFor(parse_url($this->accountApiUri, \PHP_URL_HOST)) // aud
             ->withClaim('scope', 'signature impersonation') // scope
             ->getToken(new Sha256(), new Key("file://$this->privateKey"));
     }

src/TokenEncoder/TokenEncoder.php

@@ -31,7 +31,7 @@ public function encode(array $parameters): string
 
         return password_hash(http_build_query($parameters + [
             'integration_key' => $this->integrationKey,
-        ]), PASSWORD_BCRYPT);
+        ]), \PASSWORD_BCRYPT);
     }
 
     public function isTokenValid(array $parameters, ?string $token): bool

tests/EmbeddedAuthCodeTest.php

@@ -117,6 +117,6 @@ public function testICanSignAnEmbeddedDocument(): void
         $crawler = $client->waitFor('.alert');
 
         $this->assertSame('The document has been successfully signed!', $crawler->filter('.alert')->text());
-        $this->assertSame('/embedded_auth_code', parse_url($crawler->getUri(), PHP_URL_PATH));
+        $this->assertSame('/embedded_auth_code', parse_url($crawler->getUri(), \PHP_URL_PATH));
     }
 }

tests/EmbeddedTest.php

@@ -92,6 +92,6 @@ public function testICanSignAnEmbeddedDocument(): void
         $crawler = $client->waitFor('.alert');
 
         $this->assertSame('The document has been successfully signed!', $crawler->filter('.alert')->text());
-        $this->assertSame('/embedded', parse_url($crawler->getUri(), PHP_URL_PATH));
+        $this->assertSame('/embedded', parse_url($crawler->getUri(), \PHP_URL_PATH));
     }
 }

tests/RemoteAuthCodeTest.php

@@ -92,6 +92,6 @@ public function testICanSentARemoteDocumentToBeSigned(): void
         $crawler = $client->waitFor('.alert');
 
         $this->assertSame('The document has been successfully sent to the signer!', $crawler->filter('.alert')->text());
-        $this->assertSame('/remote_auth_code', parse_url($crawler->getUri(), PHP_URL_PATH));
+        $this->assertSame('/remote_auth_code', parse_url($crawler->getUri(), \PHP_URL_PATH));
     }
 }

tests/RemoteTest.php

@@ -67,6 +67,6 @@ public function testICanSentARemoteDocumentToBeSigned(): void
         $crawler = $client->waitFor('.alert');
 
         $this->assertSame('The document has been successfully sent to the signer!', $crawler->filter('.alert')->text());
-        $this->assertSame('/remote', parse_url($crawler->getUri(), PHP_URL_PATH));
+        $this->assertSame('/remote', parse_url($crawler->getUri(), \PHP_URL_PATH));
     }
 }