Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creating new image if file is unchanged. #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix creating new image if file is unchanged. #116

wants to merge 1 commit into from

Conversation

garygreen
Copy link
Contributor

Fixes #115.

@garygreen garygreen force-pushed the fix-image-unchanged branch 3 times, most recently from 7f604d5 to f23f1a8 Compare May 18, 2016 13:19
@garygreen garygreen force-pushed the fix-image-unchanged branch from f23f1a8 to b5bd0d9 Compare May 18, 2016 13:20
@garygreen
Copy link
Contributor Author

@Gregwar any news on this?

@hirbod
Copy link

hirbod commented Jun 12, 2016

👍 really important fix

@Gregwar
Copy link
Owner

Gregwar commented Jun 12, 2016

Why the quality have to be 100 for this?

@garygreen
Copy link
Contributor Author

garygreen commented Jun 13, 2016 •
edited
Loading

Because it essentially means your not changing the image. If you wanted 100% of the original quality image, that means you just want to copy it. If it's 99% that means you want to change the image to a 1% lower quality version. That's how I see it anyway...

@garygreen
Copy link
Contributor Author

Any news @Gregwar ?

@garygreen
Copy link
Contributor Author

@Gregwar @soullivaneuh any news on this? At this rate I'll have to maintain a separate fork as this package seems quite slow on PRs at the moment.... 😢

@garygreen
Copy link
Contributor Author

@Gregwar Bump again, any news buddy? 😄

@Gregwar
Copy link
Owner

Gregwar commented Jul 19, 2016

Hello
Sorry for the delay
Shouldn't we test if the target type is also unchanged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garygreen @hirbod @Gregwar