Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove the move_value api #111

Merged
merged 1 commit into from
Oct 23, 2023
Merged

feat: remove the move_value api #111

merged 1 commit into from
Oct 23, 2023

Conversation

fengjiachun
Copy link
Contributor

@fengjiachun fengjiachun commented Oct 21, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

It is a good idea to remove the move_value API to make kv_backend simpler, we no longer need this complex and incomprehensible API,

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@MichaelScofield MichaelScofield merged commit 1d7dc6f into main Oct 23, 2023
7 checks passed
@MichaelScofield MichaelScofield deleted the feat/rm-movevalue branch October 23, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fengjiachun @MichaelScofield @WenyXu