Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support timezone in gRPC query #132

Merged
merged 1 commit into from
Jan 9, 2024
Merged

feat: support timezone in gRPC query #132

merged 1 commit into from
Jan 9, 2024

Conversation

Taylor-lagrange
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Support timezone in gRPC query

Add timezone in GreptimeRequest::RequestHeader make gRPC query aware timezone info

Because all timestamp be convert to UTC in datanode, so there is no timezone in RegionRequestHeader

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

GreptimeTeam/greptimedb#2907

waynexia
waynexia approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia enabled auto-merge (squash) January 9, 2024 03:21
@waynexia
Copy link
Member

waynexia commented Jan 9, 2024

@killme2008 @v0y4g3r PTAL

killme2008
killme2008 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit 2c1f17d into GreptimeTeam:main Jan 9, 2024
6 checks passed
@Taylor-lagrange Taylor-lagrange mentioned this pull request Jan 10, 2024
Merged
3 tasks
@killme2008 killme2008 mentioned this pull request Jan 11, 2024
Open
@Taylor-lagrange Taylor-lagrange deleted the feat-timezone branch April 15, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@killme2008 killme2008 killme2008 approved these changes

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taylor-lagrange @waynexia @killme2008