Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Create/Remove Task request #150

Merged
merged 7 commits into from
Apr 25, 2024
Merged

feat: add Create/Remove Task request #150

merged 7 commits into from
Apr 25, 2024

Conversation

discord9
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add create/remove task request, task is uniquely id-ed by it's catalog+task_name
and addition task options are added in create request.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

proto/greptime/v1/flow/server.proto Show resolved Hide resolved
proto/greptime/v1/flow/server.proto Outdated Show resolved Hide resolved
@waynexia waynexia merged commit 5d7db48 into main Apr 25, 2024
6 checks passed
@waynexia waynexia deleted the flow_request branch April 25, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants