Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Query ctx snapshots #212

Merged
merged 6 commits into from
Feb 6, 2025
Merged

feat: Query ctx snapshots #212

merged 6 commits into from
Feb 6, 2025

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Feb 6, 2025

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

add a snapshots field to query context mapping RegionId to SequenceNumber for snapshot read

Please explain IN DETAIL what the changes are in this PR and why they are needed:

frontend will query region server first for all sequence number(so to get a more consistent snapshot) for all regions involved in query if needed, and send a query context to region server with sequence snapshots

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@discord9 discord9 merged commit b5d172f into main Feb 6, 2025
7 checks passed
@discord9 discord9 deleted the query_ctx_snapshots branch February 6, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants